Enforce .NET 8 SDK for new C# modules #2046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloutiertyler
requested changes
Dec 12, 2024
Yeah, without this PR publishing C# modules stopped working altogether after Visual Studio update. Updated the testing section. |
RReverser
force-pushed
the
ingvar/force-net8
branch
from
2a8d7f2 to
f2b347a
Compare
|
@RReverser could you just confirm that you ran the tests in the testing section? |
Yes. Without this fix I can't publish modules on my machine since I installed .NET 9 (at least without manual workarounds), but with this PR I can - at least for the new modules. |
This fixes an issue where users with .NET 9 SDK installed can't build C# modules even if .NET 8 SDK is installed as well. Unfortunately, this covers only new projects created with `spacetime init` as that's the only place where we control the project directory. For everyone else, we print instructions with a link to the official configuration docs.
RReverser
force-pushed
the
ingvar/force-net8
branch
from
6965974 to
1c3619b
Compare
cloutiertyler
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This fixes an issue where users with .NET 9 SDK installed can't build C# modules even if .NET 8 SDK is installed as well.
Unfortunately, this covers only new projects created with
spacetime initas that's the only place where we control the project directory. For everyone else, we print instructions with a link to the official configuration docs.API and ABI breaking changes
If this is an API or ABI breaking change, please apply the
corresponding GitHub label.
Expected complexity level and risk
How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.
This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.
If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.
Testing
Have both .NET 8 and .NET 9 installed globally (e.g. latest Visual Studio includes .NET 9 SDK by default, and you can install .NET 8 SDK manually from the official website).
Try to init a new Spacetime C# module and publish it. Before this PR, it will fail, with this PR it will work.
I have run the above testing manually.